IRC log of #dokuwiki @ irc.libera.chat

For Sunday, 7 April 2013

  1. quit
    dommel (~dominik@g225177049.adsl.alicedsl.de) has quit (Read error: Connection reset by peer)
  2. quit
    longbeach (~mike@AFontenayssB-152-1-59-218.w82-121.abo.wanadoo.fr) has quit ()
  3. quit
    blacksad (~blacksad@ANantes-156-1-50-145.w90-12.abo.wanadoo.fr) has quit (Quit: Quitte)
  4. quit
    watrill (~quassel@unaffiliated/watrill) has quit (Ping timeout: 256 seconds)
  5. quit
    lupo49 (~quassel@v22011058783539799.yourvserver.net) has quit (Ping timeout: 246 seconds)
  6. join
    lupo49 (~quassel@v22011058783539799.yourvserver.net) entered the channel
  7. quit
    Sir_Johan (~sir_johan@dslb-088-066-196-206.pools.arcor-ip.net) has quit (Ping timeout: 264 seconds)
  8. join
    red723 (~redhair@port-92-193-81-113.dynamic.qsc.de) entered the channel
  9. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  10. quit
    red723 (~redhair@port-92-193-81-113.dynamic.qsc.de) has quit (Ping timeout: 276 seconds)
  11. quit
    SM0TVI (kvirc@unaffiliated/sm0tvi) has quit (Read error: Connection reset by peer)
  12. join
    SM0TVI (kvirc@unaffiliated/sm0tvi) entered the channel
  13. join
    shai (~Shai@l192-117-110-233.cable.actcom.net.il) entered the channel
  14. quit
    shai (~Shai@l192-117-110-233.cable.actcom.net.il) has quit (Read error: Connection reset by peer)
  15. join
    longbeach (~mike@AFontenayssB-152-1-59-218.w82-121.abo.wanadoo.fr) entered the channel
  16. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Ping timeout: 252 seconds)
  17. join
    watrill (~quassel@unaffiliated/watrill) entered the channel
  18. quit
    Ool (~Ool@unaffiliated/ool) has quit (Quit: WeeChat 0.4.1-dev)
  19. join
    Ool (~Ool@unaffiliated/ool) entered the channel
  20. quit
    watrill (~quassel@unaffiliated/watrill) has quit (Remote host closed the connection)
  21. join
    gopi1410 (~Gopi@proxy.iitk.ac.in) entered the channel
  22. quit
    gopi1410 (~Gopi@proxy.iitk.ac.in) has quit (Remote host closed the connection)
  23. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  24. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Ping timeout: 260 seconds)
  25. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  26. join
    dommel (~dominik@g225177049.adsl.alicedsl.de) entered the channel
  27. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Ping timeout: 264 seconds)
  28. quit
    Aorimn (tc@giboulees.net) has quit (Remote host closed the connection)
  29. join
    dommel1 (~dominik@g226046137.adsl.alicedsl.de) entered the channel
  30. join
    Aorimn (tc@giboulees.net) entered the channel
  31. quit
    dommel (~dominik@g225177049.adsl.alicedsl.de) has quit (Ping timeout: 256 seconds)
  32. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  33. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Read error: Operation timed out)
  34. quit
    daswort (~daswort@ubuntuusers/wikiteam/daswort) has quit (Ping timeout: 264 seconds)
  35. join
    daswort (~daswort@ubuntuusers/wikiteam/daswort) entered the channel
  36. join
    [Enrico] (~chiccoroc@gentoo/contributor/Enrico) entered the channel
  37. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  38. join
    chomwitt (~chomwitt@ppp-94-69-229-175.home.otenet.gr) entered the channel
  39. join
    RyanGulix (~Ryan2@pc-77-252-160-190.cm.vtr.net) entered the channel
  40. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Ping timeout: 264 seconds)
  41. quit
    RyanGulix (~Ryan2@pc-77-252-160-190.cm.vtr.net) has quit (Ping timeout: 245 seconds)
  42. nick
    alice_ is now known as alice_wl
  43. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  44. join
    watrill (~quassel@unaffiliated/watrill) entered the channel
  45. join
    aruna (5985510e@gateway/web/freenode/ip.89.133.81.14) entered the channel
  46. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Ping timeout: 256 seconds)
  47. join
    NEOhidra (~yaaic@213.226.63.165) entered the channel
  48. join
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) entered the channel
  49. quit
    NEOhidra (~yaaic@213.226.63.165) has quit (Client Quit)
  50. join
    Sir_Johan (~sir_johan@dslb-088-066-196-206.pools.arcor-ip.net) entered the channel
  51. quit
    redhair_ (~redhair@port-92-193-26-158.dynamic.qsc.de) has quit (Remote host closed the connection)
  52. join
    einhirn (~Miranda@p4FC758F7.dip0.t-ipconnect.de) entered the channel
  53. quit
    [Enrico] (~chiccoroc@gentoo/contributor/Enrico) has quit (Remote host closed the connection)
  54. join
    snowkat_ (~snowkat@198.46.134.56) entered the channel
  55. join
    Shao (~Shao@CPE000d936ea638-CM0014045a7c44.cpe.net.cable.rogers.com) entered the channel
  56. nick
    Shao is now known as Guest30011
  57. message at
    Guest30011
    This is driving me a little bonkers... My Fedora 17 package for DokuWiki seems ok, except that conf/ is "not writable," according to various DokuWiki interfaces. /usr/share/dokuwiki/conf is a symlink to /etc/dokuwiki/ which is owned by the apache user, with write permissions
  58. message at
    Guest30011
    &do=check says conf is not writable, for example.
  59. message at
    Guest30011
    I have used 'sudo -u apache touch /usr/share/dokuwiki/conf/foo' to test writability.
  60. message at
    Guest30011
    Does anyone know what else I might check?
  61. quit
    snowkat_ (~snowkat@198.46.134.56) has quit (Quit: ZNC - http://znc.in)
  62. message at
    Guest30011
    It was bloody SELinux.
  63. message at
    Guest30011
    Have a nic day.
  64. message at
    Guest30011
    +e
  65. quit
    Guest30011 (~Shao@CPE000d936ea638-CM0014045a7c44.cpe.net.cable.rogers.com) has quit (Quit: Leaving)
  66. join
    Hakan--S (~chatzilla@178.174.204.30) entered the channel
  67. join
    Chris--S (~Adium@87-194-159-222.bethere.co.uk) entered the channel
  68. message at
    Chris--S
    hello
  69. message at
    Hakan--S
    hi
  70. join
    splitbrain (~andi@2001:6f8:1c1a:0:922b:34ff:fe18:7138) entered the channel
  71. quit
    splitbrain (~andi@2001:6f8:1c1a:0:922b:34ff:fe18:7138) has quit (Changing host)
  72. join
    splitbrain (~andi@pdpc/supporter/active/splitbrain) entered the channel
  73. message at
    splitbrain
    'morning
  74. message at
    Hakan--S
    late start?
  75. message at
    splitbrain
    hey Hakan--S , Chris--S
  76. message at
    Chris--S
    hi
  77. message at
    splitbrain
    am I late? *looks at the clock*
  78. message at
    splitbrain
    just 3 minutes...
  79. message at
    splitbrain
    Hakan--S, so since you're here let's start with the most important thing first: what's up with the hackfest?
  80. message at
    Michitux
    hiho, I'm half afk as I'll eat in a few minuts...
  81. message at
    Michitux
    but I'll keep an eye on the screen ;)
  82. message at
    Hakan--S
    sorry, I'll be in Germany but not at the hackfest
  83. message at
    splitbrain
    :-(
  84. message at
    splitbrain
    now I'm sad.
  85. message at
    Hakan--S
    I've tried to schedule a quick visit to say hello, but even that look hard to achieve
  86. message at
    splitbrain
    this real life thing is really annoying
  87. quit
    aruna (5985510e@gateway/web/freenode/ip.89.133.81.14) has quit (Ping timeout: 245 seconds)
  88. message at
    Michitux
    btw. our hackfest is in parallel to the ohm2013(.org)
  89. message at
    splitbrain
    btw. it's also the reason for me not having done much on DokuWiki
  90. message at
    splitbrain
    so. I guess we should have a look at the pull requests?
  91. message at
    Hakan--S
    well, life has both bright and darker sides, do like Monty Python... :-)
  92. message at
    splitbrain
    Hakan--S, I hope not too dark
  93. message at
    Chris--S
    anyone know if selfthinker is joining tonight?
  94. message at
    splitbrain
    Chris--S, haven't heard from her today
  95. message at
    Hakan--S
    nothing like 50 shades anyway ;-)
  96. message at
    Chris--S
    speak of the devil :)
  97. message at
    Hakan--S
    pull requests?
  98. message at
    splitbrain
    aye
  99. message at
    splitbrain
    .oO(need to read 50 shades... even my geek friends start talking about it...)
  100. message at
    Chris--S
    ok. i think selfthinker might be along in a minute, she just came on line in gtalk.
  101. join
    selfthinker (~Anika@cpc2-walt14-2-0-cust138.13-2.cable.virginmedia.com) entered the channel
  102. message at
    splitbrain
    oh wow. that's a lot of PRs
  103. message at
    splitbrain
    alright PR#120
  104. message at
    selfthinker
    hi
  105. message at
    Chris--S
    is [bug] here?
  106. message at
    Chris--S
    hey
  107. message at
    Hakan--S
    hi selfthinker
  108. message at
    selfthinker
    Hakan--S, pity you cannot join the hackfest :(
  109. message at
    selfthinker
    splitbrain, that PR was a typo, right?
  110. message at
    selfthinker
    you meant PR#210?
  111. message at
    selfthinker
    aren't we supposed to start from the bottom?
  112. message at
    Chris--S
    we seem to change from week to week.
  113. message at
    splitbrain
    yeah I meant PR#210 - looks reasonable. I'm not to fond of the method name info_msg_canshow()
  114. message at
    Chris--S
    most of the bottom ones are from last time, for after next release
  115. message at
    splitbrain
    but the name is no blocker to me
  116. message at
    Chris--S
    i can change the name
  117. message at
    splitbrain
    I'm fine with merging
  118. message at
    Chris--S
    how about the constant names and where should they be defined?
  119. message at
    splitbrain
    good enough
  120. message at
    Hakan--S
    what about info_msg_visible() ?
  121. message at
    Chris--S
    are you ok with no auth + restricted returning false?
  122. message at
    Chris--S
    i like verbs in function names. …isvisible
  123. message at
    Hakan--S
    sure
  124. message at
    [bug]
    hi all (I'm not far, finishing dinner)
  125. message at
    selfthinker
    but shouldn't the verb come first then?
  126. message at
    selfthinker
    allows_info_msg()
  127. message at
    Chris--S
    dokuwiki style is file/category first
  128. message at
    Chris--S
    info_ indicates its from infoutils.php
  129. message at
    splitbrain
    and a comment block explaining what is passed in $msg should be added
  130. message at
    selfthinker
    info_msg_allowed()? ... anyway, I agree canshow() sounds weird
  131. message at
    splitbrain
    info_msg_allowed sounds good to me
  132. quit
    dommel1 (~dominik@g226046137.adsl.alicedsl.de) has quit (Read error: Connection reset by peer)
  133. message at
    Hakan--S
    ok, edit and merge
  134. message at
    Hakan--S
    PR#209
  135. message at
    selfthinker
    PR#209 includes PR#208 ... maybe we should have a look at the latter first?
  136. join
    dokucommit (~dokucommi@router1-ext.rs.github.com) entered the channel
  137. message at
    dokucommit
    [dokuwiki] splitbrain pushed 3 new commits to master: http://git.io/HlcouA
  138. message at
    dokucommit
    dokuwiki/master f6af1fe lupo49: de/de-informal: language updates for the core, authldap, authmysql, authpgsql
  139. message at
    dokucommit
    dokuwiki/master 83fd0ad lupo49: de/de-informal: config plugin - Clean up the TOC in the configuration page / No need to add "Konfiguration" or "Plugin" to every element if the heading tells you that.
  140. message at
    dokucommit
    dokuwiki/master 9ffcf59 Andreas Gohr: Merge pull request #209 from lupo49/localization...
  141. part
    dokucommit (~dokucommi@router1-ext.rs.github.com) has left the channel ()
  142. message at
    lupo49
    yay
  143. message at
    Chris--S
    re 210, change the array key?
  144. message at
    selfthinker
    I remember lupo49 had some merging/branching issues?
  145. message at
    Chris--S
    from 'show' to 'allow'
  146. message at
    lupo49
    no i cleared the issues by creating branches for each topic
  147. message at
    lupo49
    it's fine now
  148. message at
    splitbrain
    Chris--S, I think it would make sense to not pass $msg, but only $show
  149. message at
    Hakan--S
    and change key name
  150. message at
    Chris--S
    splitbrain, that means consumers need to know the internal data structure
  151. message at
    Chris--S
    this way checks for existence of the key are internal to the function
  152. message at
    Chris--S
    rather than cluttering up the code in html.php
  153. message at
    splitbrain
    hmm
  154. message at
    splitbrain
    okay, let's not overcomplicate that. ckean it up as you see fit and merge
  155. message at
    splitbrain
    btw. does anyone know who "José-Luis aka DarkNekros" is?
  156. message at
    splitbrain
    and how to conatct him?
  157. message at
    Hakan--S
    nope
  158. message at
    Michitux
    yes, at least the contact
  159. message at
    selfthinker
    he is sometimes in this channel
  160. message at
    selfthinker
    right now, actually
  161. message at
    splitbrain
    is it DarkNekros?
  162. message at
    selfthinker
    I would assume so ;-)
  163. message at
    Michitux
    I met him at the rmll in strasbourg in 2011
  164. message at
    splitbrain
    Michitux, do you have an email address?
  165. message at
    Michitux
    splitbrain: yes
  166. message at
    splitbrain
    alright. mail sent
  167. message at
    splitbrain
    on to the PRs
  168. message at
    splitbrain
    PR#208 is fine with me
  169. join
    mojaam (~mojaam@c-69-251-13-138.hsd1.md.comcast.net) entered the channel
  170. message at
    selfthinker
    but that was already in 209, or am I blind?
  171. message at
    splitbrain
    uh
  172. message at
    splitbrain
    was it?
  173. message at
    splitbrain
    shit
  174. message at
    selfthinker
    yes, ... that's what I said earlier why we should do 208 first
  175. message at
    splitbrain
    didn't scroll down enough ^_^
  176. message at
    splitbrain
    thought these were lang changes only O_o
  177. message at
    splitbrain
    anyway the change is fine with me, so I guess we can just clos 209 then
  178. message at
    Chris--S
    was reporting of commits on github into irc disabled?
  179. message at
    selfthinker
    nope, something else slipped in ... although unintentionally, I think
  180. message at
    splitbrain
    gah close 208 I mean
  181. message at
    selfthinker
    splitbrain, lesson learnt for today: listen more often to selfthinker! ;-)
  182. message at
    splitbrain
    hmm I wonder why 208 still applies
  183. message at
    splitbrain
    ah okay, it's actually an empty diff
  184. message at
    selfthinker
    :)
  185. message at
    splitbrain
    PR#206 is good I guess ;-)
  186. message at
    selfthinker
    yup
  187. join
    dokucommit (~dokucommi@router1-ext.rs.github.com) entered the channel
  188. message at
    dokucommit
    [dokuwiki] splitbrain pushed 2 new commits to master: http://git.io/Q9vLXw
  189. message at
    dokucommit
    dokuwiki/master ab38a32 lupo49: install.php: Added pack() to required DokuWiki PHP functions (FS#2761)
  190. message at
    dokucommit
    dokuwiki/master 0a82085 Andreas Gohr: Merge pull request #206 from lupo49/master...
  191. part
    dokucommit (~dokucommi@router1-ext.rs.github.com) has left the channel ()
  192. message at
    selfthinker
    Chris--S, I think you merged your stuff into the wrong branch?
  193. message at
    selfthinker
    "Chris--S merged commit 6772745 into authcomp from authcomp_msg 7 minutes ago"
  194. message at
    Chris--S
    was waiting until we got down to [bug]s original PR
  195. join
    delsvr (~epong@cpe-68-175-68-66.nyc.res.rr.com) entered the channel
  196. message at
    selfthinker
    ah, ok ... I thought that was the reason why you asked about the bot not announcing the merge
  197. message at
    Chris--S
    to discuss whether we were in effect agreeing to having the superuser only auth deprecated message
  198. message at
    [bug]
    Chris--S: I think we agree on that :)
  199. message at
    splitbrain
    PR#205
  200. message at
    splitbrain
    I'm not convinced this is useful
  201. message at
    Chris--S
    there don't appear to be any other opinions.
  202. message at
    selfthinker
    I don't understand what it's about, so I am neither for nor against it
  203. join
    dommel (~yaaic@g226046137.adsl.alicedsl.de) entered the channel
  204. message at
    dommel
    hi
  205. message at
    Hakan--S
    no opinion, but he actually wrote code to fix something
  206. message at
    lupo49
    hi
  207. message at
    splitbrain
    he configured his webserver to do the LDAP authentication (like a htaccess)
  208. message at
    splitbrain
    on successfull webserver login, the server provides the user name in an env var
  209. message at
    splitbrain
    but no other info
  210. message at
    Chris--S
    if its trust external, what's it to do with ldap (or any authentication) ?
  211. message at
    splitbrain
    he want's to take this env var and look up all the other data via LDAP
  212. message at
    lupo49
    and why is it in the ldap auth plugin?
  213. message at
    lupo49
    couldn't this also apply to authmysql?
  214. message at
    splitbrain
    lupo49, yes it could (if there's an apache mod to do auth against mysql - I think there is)
  215. message at
    splitbrain
    however the scenario is probably more common for ldap though
  216. message at
    Chris--S
    yup. I think there are different backends for apache auth.
  217. message at
    lupo49
    yes, but then it should be in a seperate auth plugin
  218. message at
    splitbrain
    yeah I think so too
  219. message at
    Hakan--S
    +1
  220. message at
    Chris--S
    is it a dangerous thing to be in the auth_ldap function. if its harmless and its not going to make the plugin more difficult to maintain does it matter?
  221. message at
    splitbrain
    well, it we might get exactly the same pull request for the AD auth plugin next
  222. message at
    splitbrain
    so if this is something that is useful, then it should be applied somewhere higher up the inheritance chain...
  223. message at
    Chris--S
    ok. that makes sense
  224. message at
    selfthinker
    btw, is this a feature or a bug fix?
  225. message at
    DarkNekros
    splitbrain, hi it's me
  226. message at
    splitbrain
    selfthinker, good point. definitively a feature
  227. message at
    splitbrain
    Hi DarkNekros got my email?
  228. message at
    DarkNekros
    splitbrain, tu est le mec que j'ai ranntre a Strasbourg?
  229. message at
    Michitux
    DarkNekros: afaik no, we met, and I don't think splitbrain speaks french ;)
  230. message at
    DarkNekros
    ok, I thought it was another french guy who helps you in the dokuwiki dev ^^
  231. quit
    watrill (~quassel@unaffiliated/watrill) has quit (Ping timeout: 246 seconds)
  232. message at
    DarkNekros
    splitbrain, we can continue the conversation in mp, if you wish so :)
  233. message at
    Michitux
    DarkNekros: ah, that might have been [bug]
  234. message at
    DarkNekros
    perhaps :p
  235. message at
    DarkNekros
    I have a clownfish memory :P
  236. message at
    Chris--S
    PR#205 is delayed. PR#204 is incomplete. can we jump to PR#199 and then discuss 201-203 ?
  237. message at
    selfthinker
    aren't 201-203 features?
  238. message at
    Chris--S
    no, security
  239. message at
    selfthinker
    ah, ok
  240. message at
    Chris--S
    199, is the alert for admins when they are using an incorrect authtype name
  241. message at
    Chris--S
    are we all ok with that now hte message can be targetted at admins (re 210 earlier)
  242. message at
    Hakan--S
    shouldn't the msg function changes be remove from the PR ?
  243. message at
    Chris--S
    i coded them on the branch for that PR
  244. message at
    Chris--S
    without the auth deprecated message being superuser only, its a feature and not required for this release.
  245. message at
    splitbrain
    Chris--S, yes I'm okay to show it to admins only
  246. message at
    splitbrain
    so let's merge this thing
  247. message at
    Chris--S
    ok
  248. message at
    Chris--S
    are we deleting branches are merges?
  249. join
    dokucommit (~dokucommi@router1-ext.rs.github.com) entered the channel
  250. message at
    dokucommit
    [dokuwiki] Chris--S pushed 1 new commit to master: http://git.io/kYBb8w
  251. message at
    dokucommit
    dokuwiki/master 33f1e87 Christopher Smith: Merge pull request #199 from splitbrain/authcomp...
  252. part
    dokucommit (~dokucommi@router1-ext.rs.github.com) has left the channel ()
  253. message at
    splitbrain
    Chris--S, yes. completely merged branches can and should be deleted
  254. message at
    splitbrain
    which one next?
  255. message at
    Chris--S
    210-203 ?
  256. message at
    splitbrain
    pick one
  257. message at
    Chris--S
    201 to start
  258. message at
    Chris--S
    PR#201
  259. message at
    splitbrain
    looks good to me
  260. message at
    Michitux
    +1
  261. message at
    splitbrain
    one could argue it's more a feature than a bug fix, but I see no harm in merging this
  262. message at
    splitbrain
    push the button :-)
  263. message at
    Michitux
    the bug is that there were too many cache files/wasted cpu time
  264. message at
    Chris--S
    PR#202
  265. message at
    Chris--S
    has a better explanation & discussion of the issues
  266. join
    dokucommit (~dokucommi@router1-ext.rs.github.com) entered the channel
  267. message at
    dokucommit
    [dokuwiki] Chris--S pushed 1 new commit to master: http://git.io/RGoyag
  268. message at
    dokucommit
    dokuwiki/master f20dba3 Christopher Smith: Merge pull request #201 from splitbrain/fetchissues...
  269. part
    dokucommit (~dokucommi@router1-ext.rs.github.com) has left the channel ()
  270. message at
    Chris--S
    to explain a little.
  271. message at
    Michitux
    I already added some comments to the pull request
  272. message at
    splitbrain
    202 is too much new code, for prerelease merge IMHO
  273. message at
    Chris--S
    202 has complicated code for limiting the number of resize version of an image. it might be overkill.
  274. message at
    Chris--S
    203 is simpler and prevents 3rd party get requests to fetch
  275. message at
    Chris--S
    3rd party requests are the main issue to protect against in terms of any ddos attack.
  276. message at
    splitbrain
    again, nothing I'd like to include in this release
  277. message at
    Chris--S
    if we received it as a security issue
  278. message at
    Chris--S
    we'd have to make a security release
  279. message at
    Chris--S
    why not solve it before the release?
  280. message at
    Michitux
    I like 203
  281. message at
    Chris--S
    does anyone have the origin drupal issue link?
  282. message at
    Chris--S
    i can't find my mail\
  283. message at
    Michitux
    203 might seem a lot of code but I think the actual changes to the non-testing code are rather small
  284. message at
    Chris--S
    http://drupal.org/SA-CORE-2013-002
  285. message at
    splitbrain
    i like the idea of 203
  286. message at
    splitbrain
    but, from just having a quick look at the diff I can not tell if this will break something somewhere
  287. message at
    Chris--S
    that's why I wrote all those tests
  288. message at
    Chris--S
    the separation of the fetch functions into a file of their own makes it look like more has changed than has actually changed
  289. message at
    Chris--S
    basically, image urls have an extra var added and its checked by fetch.
  290. message at
    Chris--S
    we could leave it until next meeting and someone other than me could do a more detailed review/confirmation
  291. message at
    Michitux
    I think the actual change is https://github.com/splitbrain/dokuwiki/commit/0f4e009215bfa3136d334fa557335266637a7585 while the rest is just for the tests
  292. message at
    Chris--S
    its supposed to be a completely testable change. and if someone pulls the first four commits. they get the tests before any changes to the code.
  293. message at
    Chris--S
    the last two commits are the changes.
  294. message at
    splitbrain
    okay, Michitux you're for including this?
  295. message at
    Chris--S
    ah. i'm wrong. I misread the commit list.
  296. message at
    Michitux
    splitbrain: yes, it fixes an issue that was classified as critical security issue by drupal and the change is rather small and as fetch.php and ml() should be the only places that deal with image urls I think it shouldn't break too much.
  297. message at
    splitbrain
    okay. merge it
  298. message at
    selfthinker
    "it shouldn't break too much"? would you like to rephrase that? ;-)
  299. message at
    Chris--S
    done.
  300. join
    dokucommit (~dokucommi@router1-ext.rs.github.com) entered the channel
  301. message at
    dokucommit
    [dokuwiki] Chris--S pushed 1 new commit to master: http://git.io/SYHypQ
  302. message at
    dokucommit
    dokuwiki/master 892345c Christopher Smith: Merge pull request #203 from splitbrain/fetchissues3...
  303. part
    dokucommit (~dokucommi@router1-ext.rs.github.com) has left the channel ()
  304. message at
    Chris--S
    202 for post release
  305. message at
    splitbrain
    aye
  306. message at
    Michitux
    selfthinker: well, it will break everything that doesn't use ml() for generating links to resized images
  307. message at
    selfthinker
    and what could that be? what else can you use?
  308. message at
    Chris--S
    you could self construct a link
  309. message at
    Chris--S
    possibly that's a question for Hakan
  310. message at
    selfthinker
    you mean "_media/foo/bar.png"?
  311. message at
    Michitux
    you could put a static link into the template or some other part of your website that's not from dokuwiki
  312. message at
    Chris--S
    are they any mentions of _media or fetch.php in plugins?
  313. message at
    splitbrain
    you know what it will break? screenshots in the new extension manager
  314. message at
    Michitux
    but aren't these external images anyway?
  315. message at
    selfthinker
    my abc plugin might break then
  316. message at
    selfthinker
    dw2pdf probably?
  317. message at
    splitbrain
    no, I use ml() there
  318. message at
    splitbrain
    but the new extension manger doesn't matter - that can be fixed
  319. message at
    splitbrain
    what's next?
  320. message at
    Michitux
    selfthinker: I've just had a look at your abc plugin: a) you should use ml() b) as far as I can see you don't supply any widht/height parameter
  321. message at
    Michitux
    selfthinker: the change only affects requests with a width or height parameter
  322. message at
    selfthinker
    if a plugin or template uses "_media", it will be broken without .htaccess anyway ... so, we only need to look for "fetch.php"
  323. message at
    selfthinker
    I planned to work more on the abc plugin for a few years now ;-) ... it's been over 5 years since I last laid hands on it
  324. message at
    selfthinker
    oh, I even got an issue for the ml() stuff: https://github.com/selfthinker/dokuwiki_plugin_abc/issues/1
  325. message at
    Hakan--S
    more than a single plugin uses fetch.php...
  326. message at
    selfthinker
    Hakan--S, can you attach the list in a comment to the PR?
  327. message at
    selfthinker
    I only found 2 occurrences of fetch in the about 60 templates I have here ... and those two are very old (and might even not be up-to-date on my system)
  328. message at
    Michitux
    what I wonder is: could we maybe simply return the original image when the token is invalid?
  329. message at
    Hakan--S
    can't add comments to closed PR's ?
  330. message at
    selfthinker
    Hakan--S, oh, really? :(
  331. message at
    Hakan--S
    ok, added plugins
  332. message at
    Chris--S
    I'll go through it and also look at returning the native image rather than a 412
  333. message at
    selfthinker
    two hours are over ... the next two things we might need to discuss (or might not?) are: hackfest and next release/open bugs
  334. message at
    splitbrain
    I'll send a mail to all hackfest attendees somewhen this week
  335. message at
    splitbrain
    there is at least one open LDAP-related bug I want to have a look at before the release but this will probably have to wait til end of the week
  336. message at
    selfthinker
    Michitux added this to the roadmap: FS#2760
  337. message at
    splitbrain
    yeah that should be fixed
  338. message at
    selfthinker
    can someone reproduce FS#2754?
  339. message at
    Michitux
    btw. I noticed that several other forms have this target, too
  340. message at
    Michitux
    e.g. the configuration manager
  341. message at
    splitbrain
    I'll assign dommel to FS#2754 :-)
  342. message at
    selfthinker
    splitbrain, you added this, but didn't add it to the roadmap => FS#2748 <= so, before or after the release?
  343. message at
    splitbrain
    I'd like to see this fixed before the release
  344. message at
    Michitux
    is dokuwiki.org using the latest version where this should have been fixed?
  345. message at
    selfthinker
    is this related? FS#2738
  346. message at
    splitbrain
    Michitux, dokuwiki.org is uptodate
  347. message at
    splitbrain
    selfthinker, might be related
  348. message at
    selfthinker
    splitbrain, how "secure" is the hackfest? I mean, can we all start booking tickets? :)
  349. message at
    splitbrain
    selfthinker, I'll write that in the mail. but yeah the rooms are now officially blocked for us
  350. message at
    selfthinker
    :)
  351. message at
    Chris--S
    i'll take a look at 2738 & 2748
  352. message at
    Klap-inn
    Chris--S: nice :)
  353. message at
    Klap-inn
    hi all!
  354. message at
    Chris--S
    i tend to search inc and lib when looking for functions calls. I would have missed feed.php diff function calls when doing the softbreak stuff.
  355. message at
    Michitux
    phpstorm has a nice feature "find usages" ;)
  356. message at
    splitbrain
    okay guys, I'm off
  357. message at
    splitbrain
    cya
  358. message at
    Klap-inn
    good night
  359. quit
    splitbrain (~andi@pdpc/supporter/active/splitbrain) has quit (Remote host closed the connection)
  360. message at
    Chris--S
    gn
  361. quit
    dommel (~yaaic@g226046137.adsl.alicedsl.de) has quit (Quit: Yaaic - Yet another Android IRC client - http://www.yaaic.org)
  362. message at
    Klap-inn
    Hakan--S: do you have plans with the plugin survey?
  363. message at
    Hakan--S
    well, ehh no special plans
  364. message at
    Hakan--S
    do you like a 2013 update?
  365. message at
    Klap-inn
    i like the surveys indeed!
  366. message at
    Hakan--S
    ok, not before midsummer though
  367. message at
    Klap-inn
    is there something i can help you a bit, maybe preparing some bits?
  368. message at
    selfthinker
    will you add templates to the survey in the future? :)
  369. message at
    Klap-inn
    or do you organize it offline at all?
  370. message at
    Hakan--S
    thought about that once ;-)
  371. message at
    Hakan--S
    Klap-inn: you can always try to run the script yourself, it's a dokuwiki plugin
  372. message at
    Hakan--S
    https://github.com/HakanS/dokuwiki-plugin-plugingardener
  373. message at
    Hakan--S
    there are some hardcoded settings, so you need to read to code :-)
  374. message at
    Klap-inn
    ok, nice to know, i will have a look
  375. message at
    Hakan--S
    and you need to allow_url_fopen
  376. message at
    selfthinker
    just two days ago I was thinking about adding a kind of special tagging system to the templates ... which in the end could also be some kind of a checklist ... because I have a mental checklist whenever I look at new templates and I know some are "broken" because they don't support standard stuff
  377. message at
    Hakan--S
    you probably end up with a list of 70+ plugins you need to download manually
  378. message at
    Klap-inn
    selfthinker: tagging in the meaning of calculating a quality score?
  379. message at
    Hakan--S
    I'm off to bed, gn
  380. message at
    Klap-inn
    Hakan--S: sleep well
  381. quit
    Hakan--S (~chatzilla@178.174.204.30) has quit (Quit: ChatZilla 0.9.90 [Firefox 18.0.2/20130201065344])
  382. message at
    selfthinker
    no, just tagging in the sense of adding normal template tags to it ... but from an "approved" list, so that every template shares the same potential set of tags
  383. message at
    selfthinker
    a quality score was also an idea I had a while ago ... but that would be the second step
  384. message at
    Klap-inn
    that are not tags like cms or blog? do you have an example?
  385. message at
    selfthinker
    example of the kind of tags I like to have in that list?
  386. quit
    chomwitt (~chomwitt@ppp-94-69-229-175.home.otenet.gr) has quit (Quit: Lost terminal)
  387. message at
    selfthinker
    I could start a wiki page about that ... I already have a (half complete) list ... wonder where it should best go? it would be confusing in the template namespace...
  388. message at
    Klap-inn
    yes? i think i do not have a clear idea what you mean..
  389. message at
    selfthinker
    hmm, I think I'll put something on teams:templates_gardening
  390. message at
    Klap-inn
    is it about not implementing some buttons in the interface?
  391. message at
    Klap-inn
    or about code quality?
  392. message at
    selfthinker
    it's mostly about which features are implemented, but also a bit about code quality (or rather: usability, accessiblity, etc)
  393. message at
    selfthinker
    for example: some templates have include hooks, some don't
  394. message at
    selfthinker
    I'll have a list ready in 10 minutes or s
  395. message at
    selfthinker
    +o
  396. message at
    Klap-inn
    aha
  397. nick
    Klap-inn is now known as Klap-in
  398. quit
    longbeach (~mike@AFontenayssB-152-1-59-218.w82-121.abo.wanadoo.fr) has quit ()
  399. message at
    selfthinker
    see teams:templates_gardening#feature_tags
  400. message at
    Klap-in
    dokubot: hi!
  401. message at
    Klap-in
    and this is fine... teams:templates_gardening
  402. message at
    Klap-in
    but not teams:templates_gardening#feature_tags
  403. message at
    Michitux
    dokubot doesn't support # in page ids
  404. message at
    nexraf
    Hi all
  405. message at
    Klap-in
    confirmed :)
  406. message at
    Michitux
    and afaik it has also problems if the character after the id is not a space (or eol maybe?)
  407. message at
    selfthinker
    I think foo:bar and bla:blub are okay ... just not with a character afterwards ... am I right, dokubot?
  408. message at
    selfthinker
    hmm, nope, assumed wrong
  409. message at
    Michitux
    dokubot only reacts to existing ids
  410. message at
    selfthinker
    oh, okay ... clever boy ;-)
  411. message at
    nexraf
    is it possible tu delete all the users exept me, the admin ?
  412. message at
    selfthinker
    let's try wiki:dokuwiki and wiki:syntax and see again
  413. message at
    selfthinker
    okay, works
  414. message at
    Klap-in
    and summation: wiki:dokuwiki, wiki:syntax using commas
  415. message at
    selfthinker
    I think that would only have worked, if you had left a space before the comma
  416. message at
    Klap-in
    nexraf: from the plain authentication backend?
  417. message at
    selfthinker
    someone should teach dokubot some more tricks
  418. message at
    Klap-in
    last glen has upgrade him a bit :)
  419. message at
    nexraf
    or other
  420. message at
    selfthinker
    well, as long as he's still fulfilling his most important task
  421. message at
    selfthinker
    dokubot, beer?
  422. message at
    Klap-in
    when using plain, backup your user file, create a new file with only the admin user...ready (so far i know)
  423. message at
    Klap-in
    nexraf: other backends depends on your access to them...
  424. message at
    nexraf
    ah ok
  425. message at
    nexraf
    where's the plain authentication backend?
  426. message at
    Klap-in
    you mean the configuration file with the users?
  427. message at
    nexraf
    yes
  428. message at
    Klap-in
    https://www.dokuwiki.org/auth:plain#editing
  429. message at
    Klap-in
    so in the directory [doku]/conf/
  430. message at
    nexraf
    thanks Klap-in :)
  431. quit
    mastro (~mastro@host216-66-dynamic.20-79-r.retail.telecomitalia.it) has quit (Quit: Leaving)
  432. quit
    einhirn (~Miranda@p4FC758F7.dip0.t-ipconnect.de) has quit (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
  433. quit
    Chris--S (~Adium@87-194-159-222.bethere.co.uk) has quit (Quit: Leaving.)